The current BinaryenGetFunction etc. return null if the thing is not present. Can we use the same pattern here, adding BinaryenGetDataSegment? Otherwise this has* seems like it would be a novel pattern in the C API.

The current BinaryenGetFunction etc. return null if the thing is not present. Can we use the same pattern here, adding BinaryenGetDataSegment? Otherwise this has* seems like it would be a novel pattern in the C API.

I certainly could implement a BinaryenGetDataSegment however I wanted to note that currently there is no concept of MemorySegmentRef. The behaviour of BinarenGetFunction seems fundamentally different as it returns FunctionRef, I took the Has syntax from inspiration from BinaryenHasMemory, BinaryenHasPassToSkip, BinaryenFunctionHasLocalName though i'm not sure any of those examples are exaclty the same either.

The options I see going forward here would be:

• Make all the memory segment opertaions return NULL instead of throwing if the segment doesn't exist (this doesn't feel super explcit to me so i'm not the biggest fan of this behaviour.
• Add a BinaryenGetDataSegment function, add a MemorySegmentRef, deprecate the existing name basedMemorySegment operations and implement reference based operations
• The approach I currently took.

I am happy todo any one of those, I just wanted to make sure the pr scope was clear before implementing.